Code Review
by @sydpz
Code review best practices and workflow skill. Use when: reviewing pull requests, performing peer code review, setting up code review standards, or improving...
clawhub install codereview-assistantπ About This Skill
name: code-review description: > Code review best practices and workflow skill. Use when: reviewing pull requests, performing peer code review, setting up code review standards, or improving code quality processes. Triggers: code review, PR review, pull request review, peer review, code quality, review standards, lint, static analysis. Provides: review checklist templates, focus areas by language/framework, review comment guidelines, approval criteria, and severity classification.
Code Review Skill
A structured approach to code review that balances thoroughness with efficiency.
Core Principles
1. Review the code, not the author β Assume good intent, focus on the work. 2. Be specific and constructive β Every comment should have a clear action. 3. Prioritize by severity β Not all issues are equal. 4. Approve with confidence β Don't approve code you wouldn't want to maintain.
Review Focus Areas
π΄ Critical β Must Fix Before Merge
π‘ Important β Should Fix Before Merge
π’ Nit β Consider Fixing
Review Workflow
Step 1: Understand the Context
1. Read the PR description and linked issues/tickets 2. Check what the PR is trying to accomplish 3. Understand the scope of changesStep 2: Scan First Pass
Quick scan for:Step 3: Deep Review
For each changed file: 1. Read the diff carefully 2. Cross-reference with design documents 3. Check for side effects on existing functionality 4. Verify test coverageStep 4: Classify and Comment
For each issue found, classify:[π΄ CRITICAL]
Description of the issue.
Suggested fix:
[π‘ IMPORTANT]
Description of the issue.
Suggested fix:
[π’ NIT]
Optional suggestion.
Step 5: Make a Decision
| Condition | Decision | |-----------|----------| | No critical issues, minor nits | β Approve | | Important issues need fixing | π Request Changes | | Critical issues found | β Request Changes (block merge) | | Need context/clarification | π¬ Comment (don't approve yet) |
PR Description Checklist
A good PR description should have:
Review Comment Templates
Starting a Review
I've reviewed this PR. Here's my feedback:Looking at: [files/modules]
Tested locally: [yes/no with details]
Approving
β
Approve β Code looks good, ready to merge.
Minor suggestions (non-blocking):
[nit 1]
[nit 2]
Requesting Changes
π Request Changes β Please address the following before merging:Critical:
1. [issue] β [fix suggestion]
Important:
2. [issue] β [fix suggestion]
Blocking Merge
β Blocking Merge β This PR introduces a critical issue that must be resolved:[Detailed description of the critical issue]
Per-Language/Framework Notes
Go
error handling on every function callcontext.Context propagationdefer resource cleanupgo vet)TypeScript/Node.js
any type usagePython
with statement usageJava/Kotlin
Automation Complement
Code review augments (not replaces) automated tools:
Always verify what the automation missed.
File Structure
code-review/
βββ SKILL.md
βββ references/
βββ review-checklist.md
βββ comment-templates.md
βββ severity-classification.md
βββ per-language-notes/
βββ go.md
βββ typescript.md
βββ python.md
βββ java.md